DESCRIPTION

Let pull fail gracefully when offline

Bug: 343577
Change-Id: I749482b0c2ccef69e2511048032a2305b7c42291
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2011-08-17 14:20:33.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1456/ 

-------------------------------------
author: Brenden Conley
date: 2011-08-17 14:31:47.000000000

Patch Set 1: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1456/ : UNSTABLE

-------------------------------------
author: Marley Hopkins
date: 2011-08-18 19:04:43.000000000

Patch Set 1: (2 inline comments)



Line:156, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullOperationUI.java -> I'd use an ErrorDialog.openError and pass the status in there. This way people are not confronted with the JGit error message at first (only if they want to see the details) and they're able to copy the error message

Line:534, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Wonder if we should use something like "Connection problem" instead of "Git data transfer"

I'd remove the reason, see ErrorDialog comment.

-------------------------------------
author: Douglas Trujillo
date: 2011-08-18 21:34:03.000000000

Patch Set 1: (2 inline comments)



Line:156, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullOperationUI.java -> it seems ErrorDialog always displays the reason also in the dialog area, or did I miss anything ?

Line:534, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

-------------------------------------
