DESCRIPTION

Extract 'Create Patch' into operation for reusability

In order to reuse the create patch functionality, it was extracted into
it's own operation, purely depending on JGit and decoupled from
FileDiff.

Also moved functionality for generating a filename for a specific commit
into the operation to be reusable. Tests added for the operation.

Change-Id: I6ce514ef020eacd42a94496dba80873b8e7f8743
Signed-off-by: Marley Hopkins xxx@xxx.xxx

COMMENTS

author: Marley Hopkins
date: 2011-08-10 12:20:42.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2011-08-10 12:20:46.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1393/ 

-------------------------------------
author: Brenden Conley
date: 2011-08-10 12:30:44.000000000

Patch Set 2: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1393/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2011-08-10 12:37:27.000000000

Patch Set 2: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1394/ 

-------------------------------------
author: Brenden Conley
date: 2011-08-10 12:47:15.000000000

Patch Set 2: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1394/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2011-08-10 21:54:55.000000000

Patch Set 2: I would prefer that you didn't submit this; Build Successful

(7 inline comments)



Line:2, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/CompareCoreUtils.java -> you moved some code to this class, so you should also put the copyright of the original authors here

looks weird that you use different copyright style in different files of the same patch

Line:28, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/CompareCoreUtils.java -> style nit: unnecessary blank line

Line:3, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CreatePatchOperation.java -> add the copyright statements of the authors of the code you moved from other classes to this one

Line:128, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CreatePatchOperation.java -> typo: s/contents/content/

Line:27, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CreatePatchOperationTest.java -> style nit: unnecessary blank line

Line:107, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> this formatting change looks unnecessary

Line:114, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> this formatting change looks unnecessary

-------------------------------------
author: Marley Hopkins
date: 2011-08-17 10:43:35.000000000

Patch Set 2: (7 inline comments)



Line:2, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/CompareCoreUtils.java -> Done

Line:28, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/CompareCoreUtils.java -> Done

Line:3, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CreatePatchOperation.java -> Done

Line:128, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CreatePatchOperation.java -> Done

Line:27, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CreatePatchOperationTest.java -> Done

Line:107, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> Done

Line:114, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> Done

-------------------------------------
