DESCRIPTION

Push result messages should support hyperlinks

Many code review systems (eg. Gerrit, Smartbear) provide the url to the
code review as part of the result message. To help the user
easily navigating to the code review, the message area should support
hyperlinking.

Change-Id: I87ef6022dd3804077c392eb6b3def53f7340dd48
Signed-off-by: Marley Hopkins xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2011-07-23 02:27:40.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1341/ 

-------------------------------------
author: Brenden Conley
date: 2011-07-23 02:32:39.000000000

Patch Set 1: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1341/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2011-08-08 15:16:16.000000000

Patch Set 1: I would prefer that you didn't submit this; Build Failed

(2 inline comments)

this is a nice feature :-)

It seems this change breaks the following test:

Rerun org.eclipse.egit.ui.httpauth.PushTest.testPush
testPush(org.eclipse.egit.ui.httpauth.PushTest)
org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException: Could not find widget.
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntilWidgetAppears(SWTBotFactory.java:348)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.widget(SWTBotFactory.java:308)
	at org.eclipse.swtbot.swt.finder.SWTBot.text(SWTBot.java:1175)
	at org.eclipse.swtbot.swt.finder.SWTBot.text(SWTBot.java:1163)
	at org.eclipse.egit.ui.common.PushResultDialogTester.assertResultMessage(PushResultDialogTester.java:19)
	at org.eclipse.egit.ui.httpauth.PushTest.testPush(PushTest.java:93)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.run(SWTBotJunit4ClassRunner.java:54)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.swtbot.eclipse.core.RemotePluginTestRunner.main(RemotePluginTestRunner.java:64)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.runTests(UITestApplication.java:117)
	at org.eclipse.ui.internal.testing.WorkbenchTestable$1.run(WorkbenchTestable.java:71)
	at java.lang.Thread.run(Thread.java:680)
Caused by: org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 5000 ms.: Could not find widget matching: (of type 'Text' and with text 'Repository http://127.0.0.1:53865/sbasic/test1312813637574.git')
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:398)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:372)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:360)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntilWidgetAppears(SWTBotFactory.java:346)
	... 35 more

Line:185, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> style nit: unnecessary blank line, one should be sufficient

Line:13, /COMMIT_MSG -> add a link to the corresponding bug:

Bug: 337288

-------------------------------------
author: Marley Hopkins
date: 2011-08-10 10:51:46.000000000

Patch Set 1: (2 inline comments)

Fixed remarks.

Please run the test again, something is broken with my SWTBot setup and I'm unable to run the test properly

Line:185, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:13, /COMMIT_MSG -> ha...there is a task for that :) Done

-------------------------------------
