DESCRIPTION

Don't try to compute menu for null history page inputs

Bug: 456794
Change-Id: Id14b4c06aa233af6a36ca4a0b36cd5833534dd5b
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Jayvion Booth
date: 2015-01-06 13:57:27.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-01-06 13:57:33.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6595/

-------------------------------------
author: Brenden Conley
date: 2015-01-06 14:12:55.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/6595/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2015-01-06 14:13:43.000000000

Patch Set 1: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6596/

-------------------------------------
author: Brenden Conley
date: 2015-01-06 14:28:58.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6596/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-01-07 15:51:36.000000000

Patch Set 1:

(3 comments)

Line:683, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> why do we need this variable ? Looks like just the null check would be sufficient to fix the bug

Line:684, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> style nit: we don't use braces around single line blocks

Line:844, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> why is this change needed ?

-------------------------------------
author: Jayvion Booth
date: 2015-01-07 16:51:27.000000000

Patch Set 1:

(3 comments)

Line:683, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> This class has no synchronization at all. The local variable (and new argument for the method below) is here to keep the code free from data race conditions where the field changes the state during method execution.

Line:684, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> Mist. I forget this after patching workspace code where the braces are allowed.

Line:844, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> See comment above - to avoid data race issues with field access.

-------------------------------------
