DESCRIPTION

Unify label providers in EGit

Combines all label providers into one GitLabelProvider to have a
consistent look&feel across the whole UI. Several label providers were
left out that provide a specialized version of common objects for their
use-case (eg. search results).

Change-Id: Id4c2be70d7d18a70ed928003dd81f36a2928fe58
Signed-off-by: Marley Hopkins xxx@xxx.xxx


COMMENTS

author: Marley Hopkins
date: 2011-07-16 04:47:45.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2011-07-16 05:01:20.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1301/ 

-------------------------------------
author: Brenden Conley
date: 2011-07-16 05:06:18.000000000

Patch Set 2: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1301/ : SUCCESS

-------------------------------------
author: Leslie Stephenson
date: 2011-07-17 13:13:43.000000000

Patch Set 2: (4 inline comments)



Line:43, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> is this 'f' prefix really needed ?

Line:52, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> this tailing white space isn't needed here

Line:88, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> one empty line is enough

Line:146, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> curly brackets can be removed

-------------------------------------
author: Leslie Stephenson
date: 2011-07-17 19:06:45.000000000

Patch Set 2: (1 inline comment)



Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> add copyright header

-------------------------------------
author: Jaidyn Nichols
date: 2011-07-17 20:01:12.000000000

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)



Line:159, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> This should check for repository.isBare() and use the directory name on bare repositories.

See RepositoryCommit.getRepositoryName() for an example.

-------------------------------------
author: Jaidyn Nichols
date: 2011-07-17 20:02:43.000000000

Patch Set 2: (1 inline comment)



Line:168, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Should workbenchLabelProvider.dispose be called as well when non-null?

-------------------------------------
author: Marley Hopkins
date: 2011-07-18 00:37:55.000000000

Patch Set 2: (7 inline comments)



Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Done

Line:43, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Done

Line:52, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Done

Line:88, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Done

Line:146, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Done

Line:159, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Good catch, done!

Line:168, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabelProvider.java -> Good catch! Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2011-08-01 07:12:37.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
