DESCRIPTION

Register ShellListener to detect if workbench is active

By registering a ShellListener we can avoid that the detection if the
workbench is active may freeze the UI thread.

Bug: 455468
Change-Id: I31e02f6f676c3354c6310a51283c7022d9cfe3e2
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2014-12-19 09:46:15.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-12-19 09:46:21.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/487/

-------------------------------------
author: Brenden Conley
date: 2014-12-19 10:00:17.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/487/ : UNSTABLE

-------------------------------------
author: Jayvion Booth
date: 2014-12-19 10:04:48.000000000

Patch Set 3: Code-Review-1

(1 comment)

Line:553, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Matthias, this only adds listeners to *current* shells at the startup of egit plugin, but user can open new windows after startup and close old ones - egit will not notice them at all and always report "notActive". 
As said in the bug [1], the solution to listen to existing shells is not sufficient.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=455468#c5

-------------------------------------
author: Douglas Trujillo
date: 2014-12-19 11:42:36.000000000

Patch Set 3:

(1 comment)

Line:553, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> I know that we have to watch out for newly opened shells, I just didn't yet find out which event can be used to detect them

-------------------------------------
author: Jayvion Booth
date: 2014-12-20 22:43:54.000000000

Patch Set 3:

See https://git.eclipse.org/r/38619

-------------------------------------
author: Douglas Trujillo
date: 2014-12-22 23:55:40.000000000

Abandoned

given up in favor of https://git.eclipse.org/r/#/c/38619

-------------------------------------
