DESCRIPTION

Search running launch configuration in ModalContext

Searching running launch configuration can otherwise freeze the UI
thread.

Bug: 452388
Change-Id: I6edec2ae9d7d3069ee0549e4082fdcf8e1757ace
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2014-12-10 14:19:54.000000000

Uploaded patch set 3.

-------------------------------------
author: Carlie Harper
date: 2014-12-10 15:25:25.000000000

Patch Set 3: Code-Review+1

-------------------------------------
author: Douglas Trujillo
date: 2014-12-11 00:19:06.000000000

Patch Set 3: Code-Review-1

this breaks BranchProjectTrackerTest

Rerun org.eclipse.egit.ui.internal.branch.BranchProjectTrackerTest.twoProjectsWithOnlyOneOnBranch
twoProjectsWithOnlyOneOnBranch(org.eclipse.egit.ui.internal.branch.BranchProjectTrackerTest)
org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:4441)
	at org.eclipse.swt.SWT.error(SWT.java:4356)
	at org.eclipse.swt.SWT.error(SWT.java:4327)
	at org.eclipse.swt.widgets.Display.error(Display.java:1083)
	at org.eclipse.swt.widgets.Display.checkDevice(Display.java:631)
	at org.eclipse.swt.widgets.Display.getActiveShell(Display.java:1238)
	at org.eclipse.egit.ui.internal.branch.BranchOperationUI.getShell(BranchOperationUI.java:463)
	at org.eclipse.egit.ui.internal.branch.BranchOperationUI.getRunningLaunchConfiguration(BranchOperationUI.java:619)
	at org.eclipse.egit.ui.internal.branch.BranchOperationUI.shouldCancelBecauseOfRunningLaunches(BranchOperationUI.java:547)
	at org.eclipse.egit.ui.internal.branch.BranchOperationUI.start(BranchOperationUI.java:232)
	at org.eclipse.egit.ui.internal.branch.BranchProjectTrackerTest.twoProjectsWithOnlyOneOnBranch(BranchProjectTrackerTest.java:65)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.run(SWTBotJunit4ClassRunner.java:54)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.eclipse.swtbot.eclipse.core.RemotePluginTestRunner.main(RemotePluginTestRunner.java:64)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.runTests(UITestApplication.java:117)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Testable$1.run(E4Testable.java:73)
	at java.lang.Thread.run(Thread.java:745)

-------------------------------------
author: Gerrit Johnathan Pham
date: 2014-12-15 12:48:55.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
