DESCRIPTION

bug 349895: create EGit API for launching project import from a local Git repository 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=349895
Change-Id: I4d34e9d344ffc11c54ec0e9b6e06e934e0d5b5a5

Signed-off-by: Aracely Robinson xxx@xxx.xxx

COMMENTS

author: Aracely Robinson
date: 2011-06-22 02:28:18.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2011-06-22 02:28:22.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1094/ 

-------------------------------------
author: Brenden Conley
date: 2011-06-22 02:36:41.000000000

Patch Set 3: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1094/ : SUCCESS

-------------------------------------
author: Jaidyn Nichols
date: 2011-06-22 02:49:42.000000000

Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

See comments

Line:40, org.eclipse.egit.ui/src/org/eclipse/egit/ui/EGitUI.java -> After some thought, I could see these utility classes being a bit more scoped so one class doesn't grow overly large.

What do you think of a class name of "UIProjectUtils" ?

Line:84, org.eclipse.egit.ui/src/org/eclipse/egit/ui/EGitUI.java -> style-nit: curlies not needed for single-line for loops

Line:10, /COMMIT_MSG -> Please format according to http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
author: Aracely Robinson
date: 2011-06-22 03:13:49.000000000

Patch Set 3: (1 inline comment)



Line:40, org.eclipse.egit.ui/src/org/eclipse/egit/ui/EGitUI.java -> I see your point re: class naming.  Do we anticipate lots of project-related API?  I'm ok with UIProjectUtils if so.  If not we might end up with a class with only one or two methods.

-------------------------------------
author: Aracely Robinson
date: 2011-06-22 03:18:33.000000000

Patch Set 3: Abandoned

Gerrit created a new change for my latest push: http://egit.eclipse.org/r/#change,3765

-------------------------------------
