DESCRIPTION

[stagingView] Run SubmoduleWalk in background job

Otherwise a long running walk can freeze the UI.

Bug: 439674
Change-Id: I104be3cab0f9a378bc8e01d0637c088d2af75616
Signed-off-by: Douglas Trujillo xxx@xxx.xxx
Also-By: Jayvion Booth xxx@xxx.xxx 

COMMENTS

author: Douglas Trujillo
date: 2014-12-02 13:46:30.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2014-12-02 13:46:35.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/440/

-------------------------------------
author: Brenden Conley
date: 2014-12-02 14:26:38.000000000

Patch Set 6: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/440/ : ABORTED

-------------------------------------
author: Jayvion Booth
date: 2014-12-02 14:26:56.000000000

Patch Set 6:

(2 comments)

Last small pieces missed from previous review.

Line:388, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> I'm missing the lines below as the first check in the method:

if (monitor.isCanceled() || stagingView.isDisposed())
				return Status.CANCEL_STATUS;

The forIndex(repo) call can be avoided on cancelled jobs.

Line:14, /COMMIT_MSG -> trailing space

-------------------------------------
author: Douglas Trujillo
date: 2014-12-03 07:57:27.000000000

Patch Set 6:

(2 comments)

Line:388, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:14, /COMMIT_MSG -> Done

-------------------------------------
