DESCRIPTION

[stagingView] Run SubmoduleWalk in background job

Otherwise a long running walk can freeze the UI.

Change-Id: I104be3cab0f9a378bc8e01d0637c088d2af75616
Signed-off-by: Douglas Trujillo xxx@xxx.xxx
Also-By: Jayvion Booth xxx@xxx.xxx 

COMMENTS

author: Douglas Trujillo
date: 2014-12-02 10:19:01.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-12-02 10:19:07.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/438/

-------------------------------------
author: Jayvion Booth
date: 2014-12-02 10:29:44.000000000

Patch Set 4:

(5 comments)

Line:352, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Matthias, we can't use JobFamilies.WALK_SUBMODULES here because we have two different viewers using two different contant providers for the same view *at same time*.

We should use "this" here and change the code below in belongsTo().

Line:414, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> see comment above, we should change this line to:

return this.family == other || JobFamilies.WALK_SUBMODULES == other || super.belongsTo(other);

Line:424, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> As explained above, "this" should be used as argument here.

Line:8, /COMMIT_MSG -> Missing line:
Bug: 439674

Line:13, /COMMIT_MSG -> Trailing space

-------------------------------------
author: Jayvion Booth
date: 2014-12-02 10:32:29.000000000

Patch Set 4:

(1 comment)

Line:392, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> please change the order of checks to have cheep check first. Walk.next() can freeze UI.

-------------------------------------
author: Brenden Conley
date: 2014-12-02 10:35:00.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/438/ : temporary update site https://hudson.eclipse.org/egit/job/egit-stable.gerrit/${BUILD_NUMBER}/artifact/org.eclipse.egit.repository/target/repository/

-------------------------------------
author: Douglas Trujillo
date: 2014-12-02 13:47:04.000000000

Patch Set 4:

(4 comments)

Line:352, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:392, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

but I think walk.next can't freeze the UI since it runs in a background job

Line:414, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> JobFamilies.WALK_SUBMODULES isn't used anymore

Line:424, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

-------------------------------------
