DESCRIPTION

[stagingView] Run SubmoduleWalk in background job

Otherwise a long running walk can freeze the UI.

Change-Id: I104be3cab0f9a378bc8e01d0637c088d2af75616
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2014-12-01 14:57:11.000000000

Uploaded patch set 2.

-------------------------------------
author: Jayvion Booth
date: 2014-12-01 15:06:46.000000000

Patch Set 2:

(2 comments)

Line:391, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> I would just return status here, see comment below.

Line:393, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Sorry again, if the monitor is cancelled, the job should return Status.CANCEL_STATUS. Unfortunately user can cancel *and* we might have exception, so to avoid complicated logic it would be nice to return from the catch block and write here something like
if(monitor.isCancelled())
   return Status.CANCEL_STATUS;
return Status.OK_STATUS;

-------------------------------------
author: Brenden Conley
date: 2014-12-01 15:14:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/434/

-------------------------------------
author: Douglas Trujillo
date: 2014-12-01 15:17:58.000000000

Patch Set 2:

(2 comments)

Line:391, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:393, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

-------------------------------------
author: Brenden Conley
date: 2014-12-01 15:36:11.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/434/ : UNSTABLE

-------------------------------------
