DESCRIPTION

Gracefully ignore linked resources

A project may contain resources that are not located within the
project's directory in the local file system. These resources are
referred to as linked resources.
This patch adds a few checks to gracefully ignore them in a few
functional cases: iterator, handlers, actions, etc.

Bug: 333338
CQ: 6965
Change-Id: I5005ed46cdfab47fc6913dbd46fc1291b2ac79ab
Signed-off-by: Hamza Perez xxx@xxx.xxx
Signed-off-by: Malia Sampson xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2012-12-22 21:57:56.000000000

Patch Set 15:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3883/ 

-------------------------------------
author: Brenden Conley
date: 2012-12-22 22:11:25.000000000

Patch Set 15: I would prefer that you didn't submit this

Build Unstable 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3883/ : UNSTABLE

-------------------------------------
author: Malia Sampson
date: 2012-12-22 22:12:45.000000000

Patch Set 15: Fails; I would prefer that you didn't submit this; IP review completed

The CQ is approved, we just need to take care of the failing test and have a couple other people look at the change before this goes in.

-------------------------------------
author: Douglas Trujillo
date: 2012-12-23 01:28:36.000000000

Patch Set 15: (5 inline comments)

some minore nits

Line:508, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> style nit: missing blanks around "!="

Line:99, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/GitResourceDeltaTestHelper.java -> style nit: this line looks too wide

Line:123, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/GitResourceDeltaTestHelper.java -> style nit: we don't use braces around single line blocks

Line:1074, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> why was this touched and what's the difference here ?

Line:2, org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTreeSubscriber.java -> s/20120, 2012/2010-2012/

-------------------------------------
author: Brenden Conley
date: 2012-12-23 01:29:09.000000000

Patch Set 15: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3884/ 

-------------------------------------
author: Douglas Trujillo
date: 2012-12-23 01:48:08.000000000

Patch Set 15: (5 inline comments)



Line:508, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> Done

Line:99, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/GitResourceDeltaTestHelper.java -> done, reformatted this file since it was not using project formatting settings

Line:123, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/GitResourceDeltaTestHelper.java -> Done

Line:1074, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> looks like a Gerrit problem ?

Line:2, org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTreeSubscriber.java -> Done

-------------------------------------
author: Danika Greer
date: 2012-12-23 12:55:39.000000000

Patch Set 15: (1 inline comment)



Line:2, org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTreeSubscriber.java -> Matthias: The comma notation is correct according to http://www.eclipse.org/legal/copyrightandlicensenotice.php (see {DATE} section)

-------------------------------------
author: Danika Greer
date: 2012-12-23 12:57:17.000000000

Patch Set 15: (1 inline comment)



Line:1074, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Looks like a trailing space was removed here.

-------------------------------------
