DESCRIPTION

Add RemoveFromIndex command

Adds general purpose command that removes files from git index.

Depends on jgit change I441db34f226be36548c61cef77958995971498de

Change-Id: I92a9a778d5c97f200781e970ea37a8f7c1ae191d
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2011-07-17 19:36:44.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2011-07-17 19:36:55.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1308/ 

-------------------------------------
author: Brenden Conley
date: 2011-07-17 19:41:40.000000000

Patch Set 5: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1308/ : SUCCESS

-------------------------------------
author: Carlie Harper
date: 2011-07-22 15:15:48.000000000

Patch Set 5: I would prefer that you didn't submit this

(3 inline comments)

Please see my inline comments.

Line:3355, org.eclipse.egit.ui/plugin.xml -> missing %

Line:423, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/TestRepository.java -> You change the semantics of this method. Interestingly all test cases still work. But the implementation indeed did what the method name said. The index contains the whole repository tree and not only the staged files (http://book.git-scm.com/7_the_git_index.html).

Please introduce a new method, maybe isStaged, which returns true if the index content differs from the repo content.

Line:43, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/AddOperationTest.java -> Please remove that line. It changes the tests.

-------------------------------------
author: Leslie Stephenson
date: 2011-07-22 17:24:38.000000000

Patch Set 5: (3 inline comments)



Line:3355, org.eclipse.egit.ui/plugin.xml -> Done

Line:423, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/TestRepository.java -> Done

Line:43, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/AddOperationTest.java -> Done

-------------------------------------
