DESCRIPTION

Adding CleanCommand functionality to 'Advanced' menu

Signed-off-by: Makenzie Simon xxx@xxx.xxx

Change-Id: Ibb09a9df53d678d8b0b21bcf34cab448871f5981


COMMENTS

author: Makenzie Simon
date: 2011-08-22 20:20:34.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2011-08-22 20:20:45.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1514/ 

-------------------------------------
author: Brenden Conley
date: 2011-08-22 20:32:46.000000000

Patch Set 5: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1514/ : SUCCESS

-------------------------------------
author: Leslie Stephenson
date: 2011-08-23 15:30:48.000000000

Patch Set 5: I would prefer that you didn't submit this

(9 inline comments)

Please see my inline comments

Line:74, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> we don't use curly brackets around one line statements

Line:87, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> you should at least log this exception

Line:99, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> remove TODO

Line:102, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> remove TODO

Line:106, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> remove TODO

Line:110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> remove TODO

Line:113, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> remove TODO

Line:69, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CleanOperation.java -> you will get NPE if getRepository() return null (when given resource isn't in project shared by git).

Line:74, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CleanOperation.java -> here same as above

-------------------------------------
