DESCRIPTION

Consider logical models in commit action

While commiting files to the repository, we should ask all model
providers if this set of resources is consistent in itself or if you
need to commit more resources to have a consistent model.

Bug: 346450
Change-Id: I79312945550580afee5b1c5a9fae06288a27867d
Signed-off-by: Marley Hopkins xxx@xxx.xxx


COMMENTS

author: Marley Hopkins
date: 2011-07-28 18:43:27.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2011-07-28 18:43:47.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1353/ 

-------------------------------------
author: Brenden Conley
date: 2011-07-28 18:48:43.000000000

Patch Set 6: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1353/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2011-07-31 13:52:33.000000000

Patch Set 6: I would prefer that you didn't submit this

(13 inline comments)

Is there a way to test this with a real model provider ? Could you describe how to test this.

Line:9, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> this seems to be unrelated to this change

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeOperationFactory.java -> missing license header

Line:7, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeOperationFactory.java -> - we don't use author tags
- missing javadoc for public class

Line:142, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> trailing whitespace

Line:147, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> please remove dead code

Line:151, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> trailing whitespace

Line:152, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> please remove dead code

Line:178, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> trailing whitespace

Line:18, org.eclipse.egit.ui.test/fragment.xml -> style nit: trailing whitespace

Line:128, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeUtil.java -> style nit: we don't use braces around single line blocks

Line:1066, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> typos:

s/occured/occurred/

s/commit/committing/

Line:1067, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> key name is not understandable

Line:5, org.eclipse.egit.ui.test/META-INF/MANIFEST.MF -> this seems unrelated to this change

-------------------------------------
author: Marley Hopkins
date: 2011-08-01 17:10:33.000000000

Patch Set 6: (11 inline comments)

Fixed all issues, posted notes about testing to bug 346450

Line:9, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> Done

Line:7, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeOperationFactory.java -> Done

Line:142, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> Done

Line:147, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> Done

Line:151, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> Done

Line:152, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> Done

Line:178, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java -> Done

Line:18, org.eclipse.egit.ui.test/fragment.xml -> Done

Line:1066, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

Line:1067, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

Line:5, org.eclipse.egit.ui.test/META-INF/MANIFEST.MF -> This is needed as we introduce a fragment.xml - bundles with extensions always need to be singletons as the extension registry is global

-------------------------------------
