DESCRIPTION

Fix  IAE from setStyleRanges in SpellcheckableMessageArea

setStyleRanges expects the ranges to be in order. Because UIUtils used a
set, they were not in order. But even if they're in order, hyperlink
detectors could still return overlapping results, so use individual
setStyleRange calls, which takes care of overlapping.

Bug: 446081
Change-Id: I09e223c59868742579df39961bd4b8fcacece8bc
Signed-off-by: Danika Greer xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-10-18 05:13:37.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/397/

-------------------------------------
author: Brenden Conley
date: 2014-10-18 05:29:59.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/397/ : temporary update site https://hudson.eclipse.org/egit/job/egit-stable.gerrit/${BUILD_NUMBER}/artifact/org.eclipse.egit.repository/target/repository/

-------------------------------------
author: Douglas Trujillo
date: 2014-11-07 00:04:33.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:783, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> no since tag is required since the package is internal

Line:792, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> style nit: no braces

-------------------------------------
author: Danika Greer
date: 2014-11-07 01:08:13.000000000

Patch Set 1:

(1 comment)

Line:783, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> Hm, can we move the class to the internal package in that case?

-------------------------------------
author: Douglas Trujillo
date: 2014-11-07 13:30:10.000000000

Patch Set 1:

(1 comment)

Line:783, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> all EGit packages were marked internal in the OSGi manifests in eb3ab408, we didn't move any classes in order to avoid breaking existing usages

We could clean that up in 4.0

-------------------------------------
author: Danika Greer
date: 2014-11-08 06:32:44.000000000

Patch Set 1:

(1 comment)

Line:783, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> Cool. I've started a wiki page about cleanup ideas for 4.0:

https://wiki.eclipse.org/EGit/Planning/4.0

-------------------------------------
