DESCRIPTION

[RFC] StagingView: add context menus to stage/unstage table view

Change-Id: I8ea3bb6bc9f28f3019196bdb6d2d46be55cacc2b


COMMENTS

author: Brenden Conley
date: 2011-05-19 12:02:14.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/815/ 

-------------------------------------
author: Brenden Conley
date: 2011-05-19 12:12:47.000000000

Patch Set 1: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/815/ : SUCCESS

-------------------------------------
author: Marlie Beasley
date: 2011-05-19 15:18:52.000000000

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Replac with file in git index action crashes:


org.eclipse.core.commands.ExecutionException: No selection found while executing org.eclipse.egit.ui.team.Discard
	at org.eclipse.ui.handlers.HandlerUtil.noVariableFound(HandlerUtil.java:40)
	at org.eclipse.ui.handlers.HandlerUtil.getVariableChecked(HandlerUtil.java:89)
	at org.eclipse.ui.handlers.HandlerUtil.getCurrentSelectionChecked(HandlerUtil.java:416)
	at org.eclipse.egit.ui.internal.actions.RepositoryActionHandler.getSelection(RepositoryActionHandler.java:296)
	at org.eclipse.egit.ui.internal.actions.RepositoryActionHandler.getSelectedResources(RepositoryActionHandler.java:434)
	at org.eclipse.egit.ui.internal.actions.DiscardChangesActionHandler.createOperation(DiscardChangesActionHandler.java:86)
	at org.eclipse.egit.ui.internal.actions.DiscardChangesActionHandler.execute(DiscardChangesActionHandler.java:39)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
	at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3161)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1384)

Line:366, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> CommandAction is an internal class.


/**
 * Instantiate an action that will execute the command.
 * <p>
 * This is a legacy bridge class, and should not be used outside of the
 * framework. Please use menu contributions to display a command in a menu or
 * toolbar.

Line:369, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> Nearly same code in lines [369,386] and [320, 337].

-------------------------------------
author: Marlie Beasley
date: 2011-05-19 15:23:40.000000000

Patch Set 1:

Show in history and compare with head revision actions are disabled.
If no resource exists Add to index action is enabled but fails on execution.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2011-07-05 15:55:34.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
