DESCRIPTION

Make rebase interactive view linking behaviour configurable

Now rebase interactive view has a button in the toolbar to enable and
disable linking view content with repository or resource selection.

Bug: 444660
Change-Id: I417f53fc12af34d5843a14b205ceaac1a741de79
Signed-off-by: Anahi Horn xxx@xxx.xxx

COMMENTS

author: Anahi Horn
date: 2014-10-19 19:16:56.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-10-19 19:17:02.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6424/

-------------------------------------
author: Brenden Conley
date: 2014-10-19 19:31:45.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6424/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2014-10-20 13:20:32.000000000

Patch Set 3:

Noticed this while testing and a bare repository was selected in the repositories view:

java.lang.NullPointerException
	at org.eclipse.egit.core.internal.rebase.RebaseInteractivePlan.registerIndexDiffChangeListener(RebaseInteractivePlan.java:156)
	at org.eclipse.egit.core.internal.rebase.RebaseInteractivePlan.<init>(RebaseInteractivePlan.java:147)
	at org.eclipse.egit.core.internal.rebase.RebaseInteractivePlan.getPlan(RebaseInteractivePlan.java:138)
	at org.eclipse.egit.ui.internal.rebase.RebaseInteractiveView.showRepository(RebaseInteractiveView.java:827)
	at org.eclipse.egit.ui.internal.rebase.RebaseInteractiveView.setInput(RebaseInteractiveView.java:206)
	at org.eclipse.egit.ui.internal.rebase.RebaseInteractiveView$6.selectionChanged(RebaseInteractiveView.java:487)

A bare repository should be treated as no repository I think. Could you add that? Other than that, looks good to go.

-------------------------------------
author: Danika Greer
date: 2014-10-20 13:25:38.000000000

Patch Set 3:

Ah, one more thing, I think the commit message title was still from when these changes were split up. I'd probably use something like "Link Interactive Rebase view with selected repository".

-------------------------------------
