DESCRIPTION

Make rebase interactive view linking behaviour configurable

Now rebase interactive view has a button in the toolbar to enable and
disable linking view content with repository or resource selection.

Bug: 444660
Change-Id: I417f53fc12af34d5843a14b205ceaac1a741de79
Signed-off-by: Anahi Horn xxx@xxx.xxx

COMMENTS

author: Anahi Horn
date: 2014-10-18 11:17:07.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-10-18 11:17:13.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6419/

-------------------------------------
author: Brenden Conley
date: 2014-10-18 11:32:23.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6419/ : SUCCESS

-------------------------------------
author: Anahi Horn
date: 2014-10-18 12:07:58.000000000

Patch Set 2:

Please see https://git.eclipse.org/r/#/c/33737/ for comments for the patch set 2.

-------------------------------------
author: Danika Greer
date: 2014-10-19 06:06:52.000000000

Patch Set 2:

(3 comments)

Some inline comments/questions. Otherwise looks good, nice change :).

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> I think setting defaults is usually in the PluginPreferenceInitializer class.

Line:320, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> I don't get what this whole thing does. Was this copied from somewhere else? A comment might be good here.

Line:820, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> Does `currentPlan.removeRebaseInteractivePlanChangeListener(this);` need to be done here in case it's not null? (Or rather, should the lines below that do this be moved before this if.)

-------------------------------------
author: Anahi Horn
date: 2014-10-19 19:32:33.000000000

Patch Set 2:

(3 comments)

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> Copy-pasted it from StagingView. Moved it to the PluginPreferenceInitializer, thanks for pointing this out!

Line:320, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> I assume that you are talking about IPreferenceChangeListener. I copied it from StagingView. Placed a short hint about what this listener is for, don't know how complete comment is required as this listener purpose was obvious for me in the first place for some reason :)

Line:820, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> Done

-------------------------------------
author: Danika Greer
date: 2014-10-20 13:20:37.000000000

Patch Set 2:

(1 comment)

Line:320, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> Ah, I get it now, thanks. Didn't see the connection between the pref change and `getRepositoryUtil().contains`.

-------------------------------------
