DESCRIPTION

Handle symlink icon in staging view

Handle symlink icon (blue arrow in top right corner) in staging view for
unstaged and staged changes.

Bug: 429302
Change-Id: I81816ad99685dd20baa284a156859461091aafc3
Signed-off-by: Karter Mora xxx@xxx.xxx


COMMENTS

author: Rylee Bush
date: 2014-10-09 06:51:07.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-10-09 06:51:13.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6403/

-------------------------------------
author: Brenden Conley
date: 2014-10-09 07:08:09.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6403/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2014-10-19 08:50:20.000000000

Patch Set 3: Code-Review-1

(3 comments)

Some more inline comments.

Line:342, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Putting it in this "while" means that symlinks will only be shown if there are submodules in the repository, no?

Line:439, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> revWalk needs to be release()d in a finally block.

Line:440, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> I'm not comfortable with this being inside the loop. In the worst case, it would mean we parse HEAD for every entry in the staging view. Could you change this so that it's only done once if needed?

That means processing all entries inside this function and reusing headCommit once it's initialized.

-------------------------------------
author: Rylee Bush
date: 2014-10-22 08:53:45.000000000

Patch Set 3:

(3 comments)

Line:342, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Yes, you're right, my mistake.

Line:439, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:440, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

-------------------------------------
