DESCRIPTION

Handle symlink icon in staging view

Handle symlink icon (blue arrow in top right corner) in staging view for
unstaged and staged changes.

Bug: 429302
Change-Id: I81816ad99685dd20baa284a156859461091aafc3
Signed-off-by: Karter Mora xxx@xxx.xxx


COMMENTS

author: Rylee Bush
date: 2014-09-09 11:58:04.000000000

Patch Set 2: Commit message was updated

-------------------------------------
author: Brenden Conley
date: 2014-09-09 12:12:14.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6327/

-------------------------------------
author: Brenden Conley
date: 2014-09-09 12:26:58.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6327/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2014-10-04 11:43:19.000000000

Patch Set 2: Code-Review-1

(3 comments)

Line:1749, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> testing resource is symlink -> checking if file is symlink

Line:56, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> Looks like this image was only added with Eclipse 4.4. As EGit supports older versions of Eclipse, we need to copy the icon into EGit instead.

Line:152, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> I don't think the label provider is the right place to add this. Instead, it should be set when constructing the StagingEntry objects in StagingViewContentProvider.inputChanged.

-------------------------------------
author: Douglas Trujillo
date: 2014-10-04 18:23:03.000000000

Patch Set 2: Code-Review-1

(1 comment)

Line:19, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> style nit: inconsistent whitespace, the other lines around don't use tabs

-------------------------------------
author: Rylee Bush
date: 2014-10-07 15:55:58.000000000

Patch Set 2:

(1 comment)

Line:152, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> I propose to move this code in a new method boolean isSymlink() in StagingEntry.java, and then called isSymlink() here.
Do you agree with that ?

-------------------------------------
author: Danika Greer
date: 2014-10-08 11:36:45.000000000

Patch Set 2:

(1 comment)

Line:152, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> The point is that the calculation should not be done at the point in time when the label provider is called (UI thread), but earlier.

This code here should just call isSymlink. But isSymlink should return a stored value, not compute it when getting it. To set the stored value, add it to where the StagingEntry objects are constructed, see StagingViewContentProvider.inputChanged.

-------------------------------------
author: Rylee Bush
date: 2014-10-09 06:52:04.000000000

Patch Set 2:

(4 comments)

Line:19, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Done

Line:1749, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Done

Line:56, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> Done

Line:152, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> Done

-------------------------------------
