DESCRIPTION

Make changesets order in the interactive rebase view configurable

History view sorts changesets by the age in the ascending order, while
rebase view sorts in the descending order. Now rebase interactive view
has an option to sort changesets by the age in the ascending order too.

Bug: 441925
Change-Id: I00884519258e01eb7e7994029577e29dcaf29f89
Signed-off-by: Anahi Horn xxx@xxx.xxx

COMMENTS

author: Anahi Horn
date: 2014-08-26 20:58:43.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-08-26 20:58:49.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6262/

-------------------------------------
author: Brenden Conley
date: 2014-08-26 21:17:10.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/6262/ : UNSTABLE

-------------------------------------
author: Anahi Horn
date: 2014-08-26 21:20:49.000000000

Patch Set 3: Code-Review-1

This patchset is uploaded for UI evaluation (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=441925#c10).

-------------------------------------
author: Douglas Trujillo
date: 2014-08-26 23:31:51.000000000

Patch Set 3: Code-Review-1

(13 comments)

the UI proposal looks good to me

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveDropTargetListener.java -> style nit: we don't use braces around single line blocks

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> missing license header

Line:12, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> we don't use author tags

missing javadoc

Line:41, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> style nit: no braces around single line blocks

Line:49, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> what's 123 ?

Line:51, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> this works but isn't there a simpler way to compute the step index ?

Line:83, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> strange method name

Line:84, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> style nit: no braces around single line blocks

Line:88, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> style nit: no braces around single line blocks

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> missing license header

Line:7, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> we don't use author tags but want javadoc for public classes/non-trivial public methods

Line:12, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> this javadoc doesn't make sense

Line:593, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> shouldn't this variable better be named "reverse" ?

-------------------------------------
author: Anahi Horn
date: 2014-08-27 22:30:01.000000000

Patch Set 3:

(13 comments)

Mathias, thanks for reviewing PS #3. I was planning to cleanup the code at a later stage when UI will stabilize, so it was filled with javadoc stubs, bad variable names, etc. :( Next time I will think of a better way to submit patches for UI evaluation only...

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveDropTargetListener.java -> Done

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:12, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:41, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:49, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:51, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> I was considering several ways to compute step index (https://bugs.eclipse.org/bugs/show_bug.cgi?id=441925#c7), but for different reasons this hacky approach with "indexer" was the only way I could add step to the UI without glitches and in a reasonable time.

If you have any suggestions of a better approach, please share them!

Line:83, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:84, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:88, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebasePlanIndexer.java -> Done

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> Done

Line:7, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> Done

Line:12, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractivePreferences.java -> Done

Line:593, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> Done

-------------------------------------
