DESCRIPTION

Interactive rebase view context menu for plan modification

Changeset table on the interactive rebase view now has context menu to
set rebasing plan for the selected rows.

Bug: 441891
Change-Id: I38448abbfd8d104b281aaf69cdf06702a41c3836
Signed-off-by: Anahi Horn xxx@xxx.xxx


COMMENTS

author: Anahi Horn
date: 2014-08-15 22:58:35.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-08-15 23:18:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6225/

-------------------------------------
author: Brenden Conley
date: 2014-08-15 23:34:18.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6225/ : SUCCESS

-------------------------------------
author: Kaden Henson
date: 2014-08-16 09:20:54.000000000

Patch Set 2:

(3 comments)

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/PlanContextMenuActionListener.java -> Please add "and others" to this. This way we don't need to update the header when somebody else makes changes to this file

Line:44, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/PlanContextMenuActionListener.java -> You could also use
for(Object nextSelection : structuredSelection.toList())

Line:46, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/PlanContextMenuActionListener.java -> Negating the if-condition and moving these two lines into the then-block looks nicer to me than continuing.

-------------------------------------
author: Anahi Horn
date: 2014-08-16 12:25:44.000000000

Patch Set 2:

(3 comments)

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/PlanContextMenuActionListener.java -> Done

Line:44, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/PlanContextMenuActionListener.java -> Done

Line:46, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/PlanContextMenuActionListener.java -> Was trying to stick to the approach used in other places of "rebase interactive ui" sources.

-------------------------------------
