DESCRIPTION

[historyView] Context menu item for deleting tags

The entry in the context menu triggers a function with the same features
as with the deletion of branches.
If there are multiple tags on the selected commit a dialog is shown
where the user can selected the exact tags to be deleted.

Bug: 441800
Change-Id: I5a9df7b52f0789e04242faf1833484c19494c88a
Signed-off-by: Clare Clay xxx@xxx.xxx


COMMENTS

author: Clare Clay
date: 2014-08-21 06:59:13.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-08-21 06:59:19.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6248/

-------------------------------------
author: Brenden Conley
date: 2014-08-21 07:15:51.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6248/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2014-08-21 12:12:24.000000000

Patch Set 2:

(2 comments)

Noticed that the mnemonic is missing, and one style nit.

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/DeleteTagOnCommitHandler.java -> We usually have execute first, could you move this method one down?

Line:1447, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> The mnemonic is missing (sorry, didn't notice the first time). Maybe use "e", as "d" is already taken.

-------------------------------------
author: Clare Clay
date: 2014-08-21 13:02:55.000000000

Patch Set 2:

(2 comments)

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/DeleteTagOnCommitHandler.java -> Done

Line:1447, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> I am unable to test that. I use OSX where Mnemonics are not supported! :-D

-------------------------------------
author: Danika Greer
date: 2014-08-21 13:17:23.000000000

Patch Set 2:

(1 comment)

Line:1447, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Ah :). No worries mate, tested it now.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2014-08-21 13:17:48.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
