DESCRIPTION

Commit dialog: Replace help button with link to Staging view

The help that comes up is not about the commit dialog, so showing it
only confuses users.

Instead, we can use the space to show a link to open the Staging view,
to inform the user about the alternative way of committing.

Bug: 441795
Change-Id: I616430bc9d0484b17940d679ad9ad14e277ccd7d
Signed-off-by: Danika Greer xxx@xxx.xxx


COMMENTS

author: Danika Greer
date: 2014-08-14 13:23:04.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-08-14 13:23:10.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6218/

-------------------------------------
author: Danika Greer
date: 2014-08-14 13:25:41.000000000

Patch Set 1:

Looks like this: https://bugs.eclipse.org/bugs/attachment.cgi?id=246001

-------------------------------------
author: Brenden Conley
date: 2014-08-14 13:39:16.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6218/ : SUCCESS

-------------------------------------
author: Kaden Henson
date: 2014-08-14 21:48:45.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:614, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> When the CommitDialog is opened e.g. via CommitUI.commit() closing the dialog like this will return a 0 return code, which is interpreted as a OK / commit button press, which in turn initiates a commit.

Somehow a different return code should be set before closing.

-------------------------------------
author: Danika Greer
date: 2014-08-17 07:14:54.000000000

Patch Set 1:

(1 comment)

Line:614, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> Good catch, thanks! Done.

-------------------------------------
