DESCRIPTION

[historyView] better highlighting for "interesting" files

Shows "interesting files" with bold font. Don't show intersting files in
bold font if all files in the viewer are "interesting". Control new
behavior with the new option (disabled by default) on the
Team->Git->History preference page.

Bug: 440979
Change-Id: I3f45fc6d509e2b3ad5658892a9d5b56cbee70b48
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Jayvion Booth
date: 2014-09-25 14:37:07.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-09-25 14:37:13.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6345/

-------------------------------------
author: Jayvion Booth
date: 2014-09-25 14:40:09.000000000

Patch Set 4:

Latest patch set: I've rebased the code on 3.6 HEAD. Additionally I've added new "Highlight interesting files" option to the Team->Git->History page (disabled by default) to control desired behavior.

-------------------------------------
author: Brenden Conley
date: 2014-09-25 14:52:05.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6345/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2014-10-01 06:55:29.000000000

Patch Set 4: Code-Review-1

(3 comments)

Line:40, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/FileDiffLabelProvider.java -> should be rather "highlightFont" since the user can customize fonts in Font preferences

Line:95, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/FileDiffLabelProvider.java -> this should yield the font UIPreferences.THEME_CommitGraphNormalFont but it doesn't

Line:104, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/FileDiffLabelProvider.java -> style nit: we don't use braces around single line blocks

why are you explicitly setting the style to bold ? This restricts what styles the user can choose for this font in the font preferences.

-------------------------------------
author: Douglas Trujillo
date: 2014-10-01 07:36:50.000000000

Patch Set 4:

another small problem: when changing the fonts in font preferences the history view isn't redrawn with the new font settings

-------------------------------------
author: Jayvion Booth
date: 2015-03-19 19:21:38.000000000

Abandoned

No interest anymore, default is improved now

-------------------------------------
