DESCRIPTION

Move revision classes into new package

This unclutters the org.eclipse.egit.ui.internal package a bit.

Change-Id: I4ef31c07221e80048cc31e4d73269ddab7fbd51a


COMMENTS

author: Danika Greer
date: 2014-07-05 11:17:14.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-07-05 11:17:19.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5989/

-------------------------------------
author: Brenden Conley
date: 2014-07-05 11:31:23.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5989/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2014-07-07 12:55:32.000000000

Patch Set 1:

(1 comment)

Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/FileRevisionEditorInput.java -> can we also move EgitUiEditorUtils to the new package ? Then we don't need to make this class public

-------------------------------------
author: Danika Greer
date: 2014-07-07 14:55:12.000000000

Patch Set 1:

(1 comment)

Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/FileRevisionEditorInput.java -> Does it belong with the "revision" stuff? I guess the methods taking a IFileRevision do, but not the one taking a File. Should I split the class?

On the other hand, all the methods are used for opening editors. As this is in internal packages, is making this class public bad?

-------------------------------------
author: Douglas Trujillo
date: 2014-07-07 21:46:37.000000000

Patch Set 1: Code-Review+2

(1 comment)

Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/FileRevisionEditorInput.java -> ok, you are right the package is an internal one so this doesn't make a big difference

-------------------------------------
author: Douglas Trujillo
date: 2014-07-07 21:47:40.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
