DESCRIPTION

Proper result dialog when pulling from multiple Repositories

Bug: 340780
Change-Id: I8d4aaf3f3f0b5f47cf0db50b4588a2676bb8ccc2
Signed-off-by: Willow Cantrell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2011-03-25 17:56:19.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/192/ 

-------------------------------------
author: Brenden Conley
date: 2011-03-25 18:00:02.000000000

Patch Set 1: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/192/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2011-03-31 20:54:01.000000000

Patch Set 1: (13 inline comments)

It's much better than before, good work. I added some comments.

Line:1837, org.eclipse.egit.ui/plugin.xml -> Thanks, I missed that. Should be in a separate commit or mentioned in the commit message.

Line:94, org.eclipse.egit.core/src/org/eclipse/egit/core/op/PullOperation.java -> Maybe you could extract some local variables here so that the code is not indented like this.

Line:33, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/PullFromUpstreamActionHandler.java -> how about this: new HashSet<Repository>(Arrays.asList(repos));

Line:473, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> No -> Not

Line:476, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Repositories -> repositories

Line:1016, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> status -> Status (title capitalization)

Line:1017, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Result -> result

Line:1021, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> status -> Status

Line:1022, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Result -> result

Line:1025, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Refs were updated -> refs updated
(consistency with "Nothing updated")

Line:1026, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> status -> Status

Line:1027, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> multiple -> Multiple

Line:7, /COMMIT_MSG -> Repositories -> repositories

The message should mention that it's a table with a summary and that the normal result dialog can be shown per repository.

-------------------------------------
author: Willow Cantrell
date: 2011-04-01 07:00:24.000000000

Patch Set 1: (2 inline comments)

All comments done with two small exceptions (see inline comments).

Line:476, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Well, we're not quite consistent with that in our texts, but from my UI knowledge, I'd say it should be upper case, and the majority of occurences in this file is upper case, too. The rationale from a UI point of view is that it is not a "generic" repository that's meant but a Git-specific term.

Line:1025, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Again, same as above: this is a "term", and I think it should be upper case.

-------------------------------------
author: Danika Greer
date: 2011-04-01 09:13:08.000000000

Patch Set 1: (1 inline comment)

Trying again, please see the inline reply here.

Line:476, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> There are two kinds of capitalizations styles in user interfaces: sentence and header/title, see the GNOME [1] or Apple HIG [2].

The task name should have sentence capitalization, based on what I can see from other task names in Eclipse.

In the Git man pages, "repository" is never capitalized, and they are pretty well-written. Also, looking at the CVS repository property page, they don't capitalize it either in the text. If repository is part of a title, then it should be capitalized (header capitalization), but not in sentence capitalization.

Also, we would have to capitalize many Git-specific terms, such as "branch" (it's not a branch of a tree, it's a Git branch), tag, tree..

[1] http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en#layout-capitalization
[2] http://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGText/XHIGText.html#//apple_ref/doc/uid/TP30000365-BABDIBBH

-------------------------------------
