DESCRIPTION

RevCommit is referenced after hiding blame annotations, wasting memory

Bug: 438503
Change-Id: Ia453d0e47ad5690984ab391c24d6ced56c393acf
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2014-06-29 23:17:59.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-06-29 23:18:05.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5953/

-------------------------------------
author: Brenden Conley
date: 2014-06-29 23:31:53.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5953/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2014-07-01 22:47:35.000000000

Patch Set 1: Code-Review-1

(2 comments)

when trying this change I hit many exceptions of this type:

!MESSAGE Unhandled event loop exception
!STACK 0
org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4397)
	at org.eclipse.swt.SWT.error(SWT.java:4312)
	at org.eclipse.swt.SWT.error(SWT.java:4283)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:783)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:573)
	at org.eclipse.swt.widgets.Link.removeSelectionListener(Link.java:422)
	at org.eclipse.egit.ui.internal.blame.BlameInformationControl.setInput(BlameInformationControl.java:239)
	at org.eclipse.egit.ui.internal.blame.BlameInformationControl.setVisible(BlameInformationControl.java:462)
	at org.eclipse.jface.text.AbstractInformationControlManager.hideInformationControl(AbstractInformationControlManager.java:1242)
	at org.eclipse.jface.text.AbstractHoverInformationControlManager.hideInformationControl(AbstractHoverInformationControlManager.java:788)
	at org.eclipse.jface.text.source.AnnotationBarHoverManager.hideInformationControl(AnnotationBarHoverManager.java:405)
	at org.eclipse.jface.text.AbstractHoverInformationControlManager$Closer.handleEvent(AbstractHoverInformationControlManager.java:289)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1080)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4165)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1470)

Line:176, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/blame/BlameInformationControl.java -> remove this unrelated formatting change

Line:461, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/blame/BlameInformationControl.java -> style nit: we don't use braces around single line blocks

-------------------------------------
author: Kaeden Tapia
date: 2014-07-04 01:10:38.000000000

Patch Set 1:

(2 comments)

I actually couldn't reproduce the SWTException but I added a check and hopefully it fixes it for you.

Line:176, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/blame/BlameInformationControl.java -> Done

Line:461, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/blame/BlameInformationControl.java -> Done

-------------------------------------
