DESCRIPTION

[DRAFT] task activation integration support

This change enables the automatic creation or checkout of branches
according to the activated mylyn task. If there's no context in the
task, a dialog appears, where the repositories can be selected. If
there's a context, the resources of that context are browsed and the
contained Git repositories are selected for branch creation/checkout.

Bug: 334597
Change-Id: I03b927ab8701caa13ec62e536ebdb351d11439e6
Signed-off-by: Jade Pennington xxx@xxx.xxx

COMMENTS

author: Jade Pennington
date: 2011-05-08 08:24:36.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2011-05-08 08:24:40.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/652/ 

-------------------------------------
author: Brenden Conley
date: 2011-05-08 08:32:06.000000000

Patch Set 2: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/652/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2011-05-08 21:26:57.000000000

Patch Set 2: I would prefer that you didn't submit this

(25 inline comments)

- for auto-proposed branch names I would prefer to have a prefix e.g. "bug-123456"
- I think it should be also possible to have custom branch names by enabling editing of the auto-proposed branch name before creating it
- association from repository to bug tracker could be stored as git repository configuration parameter e.g. "bugtracker.url" and integrated by implementing extension point "org.eclipse.mylyn.tasks.ui.projectLinkProviders" [1]

[1] http://wiki.eclipse.org/Mylyn_Integrator_Reference

Line:30, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> style nit: trailing whitespace

Line:31, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> style nit: trailing whitespace

Line:41, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> style nit: trailing whitespace

Line:1, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/QueryBranchMappingDialog.java -> missing license header

Line:10, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/QueryBranchMappingDialog.java -> stle nit: we don't use author tags

missing javadoc for public class

Line:1, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/AutoStart.java -> missing license header

Line:8, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/AutoStart.java -> style nit: we don't xxx@xxx.xxx tags

Line:2, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> did Chris participate here ?

Line:47, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> no author tags instead add javadoc for public class

Line:56, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> what if there are multiple repositories ? Why is the first one the right one ?

Line:59, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> instead of "origin" use DEFAULT_REMOTE_NAME from org.eclipse.jgit.lib.Constants

Line:92, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> no braces around single line blocks

Line:118, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> no braces around single line blocks

Line:123, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> why "local-1" what are semantics of this name ?

Line:156, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> properly handle exceptions

Line:162, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> replace auto-generated comment by something more meaningful

Line:2, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> why do you use Chris' copyright and not yours ?

Line:46, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> style nit: no author tags

missing javadoc

Line:61, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> missing javadoc

Line:74, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> texts shown to users must be externalized for translation

Line:114, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> why can we ignore this exception ?

Line:136, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> texts must be externalized

Line:137, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> texts must be externalized

Line:154, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> style nit: we don't use braces around single line blocks

Line:165, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> style nit: no braces around single line blocks

-------------------------------------
author: Jade Pennington
date: 2011-05-08 21:57:51.000000000

Patch Set 2: (14 inline comments)



Line:30, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> Done

Line:31, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> Done

Line:41, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> Done

Line:1, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/QueryBranchMappingDialog.java -> Done

Line:1, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/AutoStart.java -> Done

Line:2, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> Yes. He provided the first draft of this class and i extended it.

Line:56, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> Done

Line:59, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> Done

Line:92, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> Done

Line:118, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> Done

Line:123, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/TaskActivationListener.java -> I'm still experimenting with the Mylyn API to find the correct thing. "local-1" was the name of the active context, while i debugged it.

Line:2, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> Basic implementation is from Chris. I extended it.

Line:154, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> Done

Line:165, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/tasks/RepositoryAndBranchSelectionDialog.java -> Done

-------------------------------------
