DESCRIPTION

[sync] Clean up in SynchronizeViewTest

Use global INITIAL_TAG value instead of creating unique tag in test cases.

All waits for synchronization finish can be removed because
launchSynchronization() method adds specialized hook for synchronization
finish.

All common code was moved into private methods and then reused.

Change-Id: Idb63bce080ea9ed061ab64bb8004209afcac6639
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Marlie Beasley
date: 2011-02-24 09:37:16.000000000

Patch Set 1: I would prefer that you didn't submit this

First run of the test on Ubuntu was ok. Second run failed:

org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException: Could not find node with text: folder
	at org.eclipse.swtbot.swt.finder.widgets.SWTBotTreeItem.getNodes(SWTBotTreeItem.java:330)
	at org.eclipse.swtbot.swt.finder.widgets.SWTBotTreeItem.getNode(SWTBotTreeItem.java:305)
	at org.eclipse.swtbot.swt.finder.widgets.SWTBotTreeItem.getNode(SWTBotTreeItem.java:342)
	at org.eclipse.egit.ui.view.synchronize.SynchronizeViewTest.getCompareEditorForFileInGitChangeSet(SynchronizeViewTest.java:560)
	at org.eclipse.egit.ui.view.synchronize.SynchronizeViewTest.shouldOpenCompareEditorInGitChangeSet

-------------------------------------
author: Marlie Beasley
date: 2011-02-24 09:39:42.000000000

Patch Set 1:

Three runs on Windows 7 ok, Run #4 failed:

java.lang.AssertionError: 
Expected: "Touched at 1298540144183"
     got: "<!-- EGit jUnit test case -->Touched at 1298540144183"

	at org.junit.Assert.assertThat(Assert.java:778)
	at org.junit.Assert.assertThat(Assert.java:736)
	at org.eclipse.egit.ui.view.synchronize.SynchronizeViewTest.shouldExchangeCompareEditorSidesBetweenIncomingAndOutgoingChangesInGitChangeSet(SynchronizeViewTest.java:233)

-------------------------------------
