DESCRIPTION

Remove redundant secure store accessor methods

Change-Id: I276433189e4b2fcf1c76049dd6ae72f16a37150d
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2014-05-12 21:10:03.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-05-12 21:57:04.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5861/

-------------------------------------
author: Brenden Conley
date: 2014-05-12 22:12:07.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5861/ : SUCCESS

-------------------------------------
author: Juliet Cantu
date: 2014-05-13 13:59:20.000000000

Patch Set 2: Code-Review-1

(1 comment)

Line:821, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> With true, credentials will aleways be non-null, unless an exception occurs.

Other than that, I think this is ugly. Create two utility methofs instead.

Maybe we need to tests for this?

-------------------------------------
author: Douglas Trujillo
date: 2014-05-13 22:06:36.000000000

Patch Set 2: Code-Review-1

(1 comment)

Line:821, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> got me, boolean parameters are suspicious

-------------------------------------
author: Douglas Trujillo
date: 2014-05-13 22:45:50.000000000

Patch Set 2:

(1 comment)

Line:821, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> no, StorageException is only thrown if decryption of credentials failed, but null will be returned if no credentials are found in the secure store for the given uri

-------------------------------------
