DESCRIPTION

[Rebase Interactive] Move multiple commits

This change is implementing moving multiple commits with the move
buttons. Drag and Drop will be done in another change.

Bug: 431214
Change-Id: Ifcb97a495a3a938f86d3a7370f61b777cd7b3672
Signed-off-by: Carlie Harper xxx@xxx.xxx

COMMENTS

author: Carlie Harper
date: 2014-03-28 15:30:50.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-03-28 15:30:56.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5661/

-------------------------------------
author: Brenden Conley
date: 2014-03-28 15:45:13.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5661/ : SUCCESS

-------------------------------------
author: Kaden Henson
date: 2014-03-29 21:27:45.000000000

Patch Set 1: Code-Review-1

(6 comments)

Line:162, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> When you move up all the A lines in
A1
A2
B
A3

It mixes up A1 and A2:
A2
A1
A3
B

Line:181, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Movng down can similarily mix up elements

Line:230, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> This method is no longer used.

Line:285, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Maybe rename to "lastSelectedEntry" (keeping the "entry" name in the for loop)

Line:294, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> the break statement can cause "entry" to not to contain the last selected entry after the for loop

Line:12, /COMMIT_MSG -> The change seems unrelated to this bug report

-------------------------------------
author: Carlie Harper
date: 2014-03-31 13:56:01.000000000

Patch Set 1:

(6 comments)

Line:162, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Good catch!

I now just do not allow to move lines if the first line is selected when moving up or when the last line is selectd when moving down.

Line:181, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Done

Line:230, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Done

Line:285, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Done

Line:294, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Done

Line:12, /COMMIT_MSG -> Done

-------------------------------------
