DESCRIPTION

Branches and Tags links in commit message viewer

Some analog of 'gitk' utility links. Added following info to commit
message viewer:
Branches - links to branch refs
Tags - list of tags pointing to this commit
Follows - link to previous tag in history
Precedes - link to next tag in history

Bug: 336223

Change-Id: I1c61d2c7eca14ba534302eec6e38bdbe85e0107f
Signed-off-by: Isabella Carey xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2011-02-03 14:19:28.000000000

Patch Set 1: I would prefer that you didn't submit this

(14 inline comments)



Line:334, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> please remove brackets

Line:420, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> please remove brackets

Line:432, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> please remove brackets

Line:434, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> please remove brackets

Line:448, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> one empty line between methods is enough ;)

Line:644, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> brackets, once again ;)

Line:653, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> remove brackets

Line:656, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> remove brackets

Line:660, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> please remove empty line

Line:667, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> this method looks exactly the same as getAncestorTag(), maybe you can extract common code into private method?

Line:720, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java -> remove brackets

Line:290, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> this line should be inside if (oldList != list), or outside?
If inside, please add brackets otherwise remove indentation.

Line:298, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java -> please remove brackets since we don't use brackets for single line statements

Line:17, /COMMIT_MSG -> remove this new line

-------------------------------------
author: Gerrit Johnathan Pham
date: 2011-02-03 20:39:05.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
