DESCRIPTION

Tree Compare: show in single tree with icons

Instead of showing two trees, the information is now displayed in a
single tree with "Added" "Deleted", "Changed" icons.

Change-Id: I4cb70d8ec49c1bdb16c74b5bee929046b8d47e12
Signed-off-by: Willow Cantrell xxx@xxx.xxx


COMMENTS

author: Willow Cantrell
date: 2011-01-31 08:40:50.000000000

Uploaded patch set 2.

-------------------------------------
author: Willow Cantrell
date: 2011-01-31 08:41:58.000000000

Patch Set 2:

Fixed issues with opening compare editor on deleted file and another issue which resuls in "Reentrant call ignored" warnings in the error log.

-------------------------------------
author: Douglas Trujillo
date: 2011-01-31 21:30:17.000000000

Patch Set 2: I would prefer that you didn't submit this

(12 inline comments)



Line:1110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> there is no left and right tree anymore, only one tree is displayed ...

Line:802, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> maybe better call this "addedPaths" instead of "leftOnlyPaths" ?

Line:805, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> maybe better call this "deletedPaths" instead of "rightOnly" ?

Line:816, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> typo: s/abd/and/

Line:820, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> why these funny steps for the int values ?

Line:850, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> style nit: no braces

Line:858, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> style nit: no braces

Line:861, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> style nit: no braces

Line:879, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> style nit: no braces

Line:899, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> any example what unknown could be ?

Line:1000, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> are there better names than left and right here ?

Line:1066, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> style nit: no braces

-------------------------------------
author: Willow Cantrell
date: 2011-02-01 07:06:44.000000000

Patch Set 2: (11 inline comments)



Line:802, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:805, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:816, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:820, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> No particular reason. It may be easier to put something in between later.

Line:850, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:858, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:861, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:879, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

Line:899, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> No, but unfortunately, this API is not type-safe.

Line:1000, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> renamed left... to base... and right... to compare...

Line:1066, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2011-02-01 07:07:38.000000000

Patch Set 2: (1 inline comment)



Line:1110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java -> Done

-------------------------------------
