DESCRIPTION

Fix incorrect review url in IP log file

Change-Id: I33e64c9953507590d51906c76a45eb581fad9a50
Signed-off-by: Malia Sampson xxx@xxx.xxx


COMMENTS

author: Malia Sampson
date: 2011-01-31 15:31:12.000000000

Uploaded patch set 2.

-------------------------------------
author: Malia Sampson
date: 2011-01-31 15:31:27.000000000

Change has been successfully merged into the git repository.

-------------------------------------
author: Malia Sampson
date: 2011-01-31 15:31:27.000000000

Patch Set 2: Looks good to me, approved; Build Successful; IP review completed

Looks fine.

-------------------------------------
author: Douglas Trujillo
date: 2011-01-31 15:42:30.000000000

Patch Set 2:

I think this is plain wrong, citing a private mail from Shawn:


2010/5/29 Jaycee Hickman xxx@xxx.xxx
> Douglas Trujillo xxx@xxx.xxx wrote:
>> 2010/5/29 Jaycee Hickman xxx@xxx.xxx
>> >
>> > Yea, I found that bug myself today, and fixed it.  So I closed
>> > 314964.  Sorry you spent time on a bug, thinking its user error.
>> >
>>
>> no problem
>>
>> I think the review URL you added in
>> http://egit.eclipse.org/r/#patch,unified,770,1,.eclipse_iplog
>> <http://egit.eclipse.org/r/#patch,unified,770,1,.eclipse_iplog>has an extra
>> trailing r/ :
>>     http://egit.eclipse.org/r/r/
>> which should be removed.
>
> Nope, its correct.  It looks funny, yes, but its correct.
>
> The first /r/ tells our Apache to redirect the request to Gerrit.
>
> The second /r/ tells Gerrit that the thing following is a Git
> SHA-1 and it should try to locate the change(s) that use that
> commit object.
>
> Nothing I can easily do about it now.  The second /r/ is historical
> and comes from Gerrit 1.x days.  The first /r/ was a foolish
> mistake when I setup the egit.eclipse.org Apache configuration.
> Its modeled after how I set it up within Google... so I've made
> that stupid mistake twice now.  Yay.
>
> --
> Shawn.

-------------------------------------
author: Malia Sampson
date: 2011-01-31 15:45:25.000000000

Patch Set 2:

I'll revert the change and add a note.

That's a bit esoteric.

-------------------------------------
