DESCRIPTION

GTK multi pull result dialog layout minimum height

On GTK the multi pull result dialog only has 2 lines visible,
independent of how many repositories have been pulled. This change
adapts the height dynamically depending on the number of repositories
(with a fixed maximum of 15 lines). Do you prefer just using a fixed
pixel size instead of dynamically calculating it?

I have not tested the change on any other window system. 

Change-Id: I78d227672aca0249dfcaf162653bb0971a9f966c
Signed-off-by: Jack Yu xxx@xxx.xxx


COMMENTS

author: Jack Yu
date: 2014-03-16 08:10:51.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-03-16 08:10:57.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5623/

-------------------------------------
author: Brenden Conley
date: 2014-03-16 08:24:27.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/5623/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2014-03-17 22:08:40.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:206, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/MultiPullResultDialog.java -> there is no need for an extra empty line, so remove +1

Line:12, /COMMIT_MSG -> better ask questions / comment in review comments then we don't have to amend the commit message

-------------------------------------
author: Douglas Trujillo
date: 2014-03-17 22:09:33.000000000

Patch Set 1:

(2 comments)

Line:206, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/MultiPullResultDialog.java -> Done

Line:12, /COMMIT_MSG -> Done

-------------------------------------
