DESCRIPTION

Open workspace version from context menu of the compare editor

Bug: 426614
Change-Id: I93393f73d0ba246c45e2d9918b06bcefd9334e1f
Signed-off-by: Kaden Henson xxx@xxx.xxx

COMMENTS

author: Kaden Henson
date: 2014-03-15 12:42:49.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-03-15 12:46:22.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5613/

-------------------------------------
author: Brenden Conley
date: 2014-03-15 12:59:35.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5613/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2014-03-29 18:00:00.000000000

Patch Set 1:

(3 comments)

Line:482, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitCompareFileRevisionEditorInput.java -> Would be nice to also have this for IndexFileRevision.

Line:493, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitCompareFileRevisionEditorInput.java -> SaveablesCompareEditorInput.handleMenuAboutToShow (the code that adds "Open" to local file compare context menu) uses the "file" group (not "save"). It looks like you can also get rid of the separator when you use the "file" group.

Line:527, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitCompareFileRevisionEditorInput.java -> I like this, attention to detail :).

-------------------------------------
author: Kaden Henson
date: 2014-03-29 19:38:53.000000000

Patch Set 1:

(2 comments)

Line:482, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitCompareFileRevisionEditorInput.java -> Done. Moved both required methods to new OpenWorkspaceVersionEnabled interface, which both Revisions now implement

Line:493, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitCompareFileRevisionEditorInput.java -> Done. Works nicely.

-------------------------------------
