DESCRIPTION

Make "Compare with -> Git Index" work with folders and projects

Bug: 315555
Change-Id: I7df2c870b24a9f37775735bcab530c322f807d51
Signed-off-by: Willow Cantrell xxx@xxx.xxx


COMMENTS

author: Willow Cantrell
date: 2011-01-26 20:20:55.000000000

Uploaded patch set 3.

-------------------------------------
author: Willow Cantrell
date: 2011-01-26 20:23:58.000000000

Patch Set 3:

Now checking for ignored.

-------------------------------------
author: Leslie Stephenson
date: 2011-01-26 20:45:59.000000000

Patch Set 3:

How should work "Show added files only" button?

I've test it and it seams that when this option is enabled the content of left hand side column dissimilars even when I have some staged file inside the folder that I'm comparing. But I don't see any useful case for this behavior.

-------------------------------------
author: Leslie Stephenson
date: 2011-01-26 20:52:47.000000000

Patch Set 3: Looks good to me, but someone else must approve; Build Successful; IP review completed

OK, I think that I misunderstood "added" as a "added to git index", maybe in the feature we can change this tooltip text into "Show new files only" or "Show created files only" to don't have such misunderstandings.

-------------------------------------
author: Douglas Trujillo
date: 2011-01-26 21:53:26.000000000

Patch Set 3: I would prefer that you didn't submit this

I hit this NPE on one project I tried to compare

eclipse.buildId=M20100909-0800
java.version=1.6.0_22
java.vendor=Apple Inc.
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=en_US
Framework arguments:  -product org.eclipse.platform.ide
Command-line arguments:  -product org.eclipse.platform.ide -data /Users/d029788/Documents/workspace/egit/../runtime-New_configuration -dev file:/Users/d029788/Documents/workspace/egit/.metadata/.plugins/org.eclipse.pde.core/EGit/dev.properties -os macosx -ws cocoa -arch x86_64 -consoleLog


Error
Wed Jan 26 22:47:44 CET 2011


java.lang.NullPointerException
at org.eclipse.egit.core.internal.storage.CommitFileRevision.<init>(CommitFileRevision.java:59)
at org.eclipse.egit.core.internal.storage.GitFileRevision.inCommit(GitFileRevision.java:50)
at org.eclipse.egit.ui.internal.dialogs.CompareTreeView.buildMaps(CompareTreeView.java:737)
at org.eclipse.egit.ui.internal.dialogs.CompareTreeView.access$25(CompareTreeView.java:614)
at org.eclipse.egit.ui.internal.dialogs.CompareTreeView$12.run(CompareTreeView.java:584)
at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

When multi-selecting multiple projects the menu entry gets disabled, would be nice if this would work also (tried with set of egit projects which all reside in same repository)

-------------------------------------
