DESCRIPTION

Support 'Open corresponding task'

Implemented repository url resolving.
Algorithm based on assumption that Mylyn task repository and remote
git repository (origin) are on the same host.

Change-Id: I18af5f3dcfa080cfb46d9e38ea91a9e55a634071
Signed-off-by: Aniyah Best <Isabella xxx@xxx.xxx


COMMENTS

author: Carla Osborn
date: 2011-01-25 17:24:33.000000000

Uploaded patch set 4.

-------------------------------------
author: Carla Osborn
date: 2011-01-25 17:40:03.000000000

Patch Set 4:

Now task repository url is taken from repository config value "bugtraq.url".
Also fixed new lines and some warnings.

-------------------------------------
author: Leslie Stephenson
date: 2011-01-25 18:08:15.000000000

Patch Set 4: (12 inline comments)

Minor code style hints.

Line:57, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:89, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:96, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:109, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:132, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> In deed it should be logged, and way it isn't?

Line:143, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:156, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:171, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:183, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:187, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:191, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

Line:196, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/TaskReferenceFactory.java -> style nit: we don't use curly brackets in single line blocks

-------------------------------------
author: Lexie Bruce
date: 2011-01-25 18:36:35.000000000

Patch Set 4:

@Matthias The implementation could check the optional property "bugtraq.url" and if available taking the host from that URL. If "bugtraq.url" is not available in the config file, we could assume that git and task repositories are on the same host.

What do you think?

-------------------------------------
