DESCRIPTION

Add initial EGit Mylyn integration

Change-Id: I344546626c8cb089c019db08afa400e4847e6fc4
Signed-off-by: Malia Sampson xxx@xxx.xxx
Signed-off-by: Marley Hopkins xxx@xxx.xxx

COMMENTS

author: Marley Hopkins
date: 2011-01-17 16:56:47.000000000

Uploaded patch set 3.

-------------------------------------
author: Juliet Cantu
date: 2011-01-17 20:51:38.000000000

Patch Set 3: I would prefer that you didn't submit this

(11 inline comments)

This patch is based on abandoned patch!?

Line:22, org.eclipse.egit.mylyn.ui/META-INF/MANIFEST.MF -> Wby not Import-Package?

Line:1, org.eclipse.egit.mylyn.ui/.gitignore -> Add trailing/ for diretories

Line:25, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java -> trailing whitespace

Line:46, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/EGitMylynUI.java xxx@xxx.xxx is enough

Line:21, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/CommitDialogExtender.java -> Some javadoc to explaint this class would be nice

Line:27, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/CommitDialogExtender.java -> We don't xxx@xxx.xxx tags. Add these people to the
copyright header.

Line:30, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/CommitDialogExtender.java -> Use the @return xxx@xxx.xxx taga

Line:38, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/CommitDialogExtender.java -> We avoid braces for omeline ifs like these

Line:50, org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/commit/CommitDialogExtender.java -> Why do these two methods exist?

Line:4, org.eclipse.egit.mylyn.ui/plugin.xml -> away-commented?

Line:2, org.eclipse.egit.mylyn-feature/.gitignore -> Use bin/ and target/ for directories

-------------------------------------
author: Douglas Trujillo
date: 2011-01-17 21:56:26.000000000

Patch Set 3: (6 inline comments)



Line:21, org.eclipse.egit.mylyn-feature/feature.xml -> I would expect this to be part of the main egit p2 repo (not pde)

Line:26, org.eclipse.egit.mylyn-feature/feature.xml -> why do we need this dependency ?
that doesn't look like it's Galileo compatible...

Line:29, org.eclipse.egit.mylyn-feature/feature.xml -> shouldn't this have .qualifier ?

Line:20, org.eclipse.egit.mylyn.ui/META-INF/MANIFEST.MF -> in all other egit and jgit bundles we use package dependencies on jgit and egit with version range [0.11,0.12)

Line:26, org.eclipse.egit.mylyn.ui/META-INF/MANIFEST.MF -> missing version specifier 0.11.0.qualifier

Line:27, org.eclipse.egit.mylyn.ui/META-INF/MANIFEST.MF -> missing version specifier 0.11.0.qualifier

-------------------------------------
