DESCRIPTION

Refactor a utility to get a list of RefNodes from a commit

Change-Id: Id3d6ef20a309051ff084cef088b2c71e2a83ed3d
Signed-off-by: Juliet Cantu xxx@xxx.xxx


COMMENTS

author: Juliet Cantu
date: 2011-01-08 08:25:19.000000000

Uploaded patch set 2.

-------------------------------------
author: Douglas Trujillo
date: 2011-01-10 00:13:41.000000000

Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)



Line:137, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommanndHandler.java -> typo: s/ambiguos/ambiguous/

Line:141, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommanndHandler.java -> missing double quote ? "refs/heads/"

Line:148, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommanndHandler.java -> if refPrefix would be "refs/remotes/origin/" would this still yield local branches ?

Line:151, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommanndHandler.java -> style nit: no braces around single line block

-------------------------------------
author: Juliet Cantu
date: 2011-01-15 23:42:27.000000000

Patch Set 2: (2 inline comments)



Line:148, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommanndHandler.java -> This works as before. The code has just been moved. 
Will fix.

Line:151, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommanndHandler.java -> If I don't change the braces peopl can still blame the original author.

Clearning up. Done.

-------------------------------------
