DESCRIPTION

Disable cleaning if selection is empty.

The current implementation runs the git clean command even if no file or
directory is selected in the clean wizard. That may take quite some time
and may lead to cleaning the repository although the user expected
nothing to be cleaned.

Change-Id: If59bd58b0204a069d9cf77b5ffa05d4d566cf802
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Danika Greer
date: 2014-02-14 15:17:25.000000000

Patch Set 1:

(1 comment)

One minor comment, otherwise LGTM.

Line:171, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clean/CleanRepositoryPage.java -> The documentation of DialogPage#setMessage says a null String should be used to clear the message.

-------------------------------------
author: Jack Yu
date: 2014-02-15 15:12:18.000000000

Patch Set 1: Code-Review+1

-------------------------------------
author: Douglas Trujillo
date: 2014-02-16 16:02:24.000000000

Patch Set 1:

(1 comment)

Line:171, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clean/CleanRepositoryPage.java -> Done

-------------------------------------
