DESCRIPTION

Created an extension point to extend the commit message.

To integrate Mylyn's commit templates an extension point
is needed. This extension point provides an interface you
must implement. During the preparation of the commit
dialogs the extensions using this extension points will be
requested for a message to add to the dialog.
Here is a sample configuration:
<extension
    point="org.eclipse.egit.ui.commitMessageProvider">
    <commitMessageProvider
        class="org.eclipse.egit.mylyn.CommitMessageProvider">
    </commitMessageProvider>
</extension>
The mylyn integration is done. You will find them in the
org.eclipse.egit.mylyn project. The implementation of the
ICommitMessagProvider has the ability to check if there are a
project-specific configuration for mylyn's commit message templates.
Change-Id: I3e0b8cd23be957c8c6a8199ce6818282fb24dc68


COMMENTS

author: Kennedi Macias
date: 2011-01-07 08:30:55.000000000

Uploaded patch set 9.

-------------------------------------
author: Kennedi Macias
date: 2011-01-07 08:34:12.000000000

Patch Set 9:

Now I have renamed the wrong typed directory (egilt) into the correct name :o

I hope we can now take a look onto the implementation and a +1 :)

-------------------------------------
author: Juliet Cantu
date: 2011-01-08 08:46:14.000000000

Patch Set 9: I would prefer that you didn't submit this

(3 inline comments)

according to 

git ls-files -z|xargs -0 grep egilt

there are still a few occurrences.

I'd like someone from the Mylyn team review this too.

Line:13, /COMMIT_MSG -> newline

Line:21, /COMMIT_MSG -> newline

Line:24, /COMMIT_MSG -> newline

-------------------------------------
author: Douglas Trujillo
date: 2011-01-08 22:58:07.000000000

Patch Set 9: I would prefer that you didn't submit this

(15 inline comments)



Line:4, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/internal/MylynCommitMessageProvider.java -> style nit: unnecessary 2nd blank line

Line:10, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/internal/MylynCommitMessageProvider.java -> typo in package name s/egilt/egit/

Line:21, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/internal/MylynCommitMessageProvider.java -> typo: s/integartion/integration/

Line:39, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/internal/MylynCommitMessageProvider.java -> if we always pass true here, what will happen if we are offline and cannot access the task repository currently ?

Line:25, org.eclipse.egit.mylyn/pom.xml -> this is not egit ui but mylyn integration 

Git Team Provider (Mylyn Integration) (Incubation)

Line:20, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> typo in package name: s/egilt/egit/

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider.java -> don't attribute copyright to Eclipse Egit Team, instead use your name and email or your company

style nit: avoid 2nd unnecessary blank line

Line:21, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider.java -> typo: s/Primarily/Primary/

Line:25, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider.java -> style nit: we don't use author tags

Line:91, org.eclipse.egit.ui/schema/commitMessageProvider.exsd -> I am not sure if this generic copyright note is ok

Line:468, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> this line looks a bit long, use code formatting options as specified in contributor guide and configured in project preferences

style nit: there is an unnecessary blank before the semicolon

Line:10, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/EgitMylynPlugin.java -> typo in package name s/egilt/egit/

Line:33, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/EgitMylynPlugin.java -> style nit: trailing whitespace

Line:40, org.eclipse.egit.mylyn/src/org/eclipse/egilt/mylyn/EgitMylynPlugin.java -> style nit: trailing whitespace

Line:24, /COMMIT_MSG -> Git also can define commit templates. What's the intended relationship to Mylyn commit templates ? See git configuration parameter commit.template in [1].

[1] http://www.kernel.org/pub/software/scm/git/docs/git-config.html

-------------------------------------
