DESCRIPTION

Created an extension point to extend the commit message.

To integrate Mylyn's commit templates an extension point
is needed. This extension point provides an interface you
must implement. During the preparation of the commit
dialogs the extensions using this extension points will be
requested for a message to add to the dialog.

Here is a sample configuration:
<extension
    point="org.eclipse.egit.ui.commitMessageProvider">
    <commitMessageProvider
        class="org.eclipse.egit.mylyn.CommitMessageProvider">
    </commitMessageProvider>
</extension>

The mylyn integration is done. You will find them in the
org.eclipse.egit.mylyn project. The implementation of the
ICommitMessagProvider has the ability to check if there are a
project-specific configuration for mylyn's commit message templates.

Change-Id: I3e0b8cd23be957c8c6a8199ce6818282fb24dc68


COMMENTS

author: Kennedi Macias
date: 2011-01-12 20:09:01.000000000

Uploaded patch set 11.

-------------------------------------
author: Marley Hopkins
date: 2011-01-17 13:41:32.000000000

Patch Set 11: I would prefer that you didn't submit this

(17 inline comments)

Several minor issues, doesn't apply cleany currently. I think we can handle this today/tomorrow as part of the EGit summit.

Line:2, org.eclipse.egit.mylyn/plugin.properties -> You're not Shawn

Line:9, org.eclipse.egit.mylyn/plugin.properties -> I'd call it Mylyn integration

Line:23, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/internal/MylynCommitMessageProvider.java -> Would put the SupressWarnings in a more narrow scope to only hide the use of ContextChangeSet

Line:496, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> Please use EgitMylynPlugin to handle errors in this bundle

Line:502, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> Please use EgitMylynPlugin to handle errors in this bundle

Line:5, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> align with EGit version

Line:14, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> resources seems not to be used

Line:19, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> Bundle-Localization: plugin is missing in order to get the properties resolved

Line:20, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> We should take care to split API vs non-API. Please export internal packages as x-internal.

Line:4, org.eclipse.egit.ui/plugin.xml -> We should mark this as internal ext point for now, i don't see the maturity for this to be API yet

Line:21, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Should be named EGitMylynPlugin like all other EGit classes

Line:43, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> whitespace nit

Line:54, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> whitespace nit

Line:64, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> whitespace nit

Line:72, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Should use proper plugin id

Line:5, org.eclipse.egit.mylyn/plugin.xml -> Should we use .mylyn in the extension point id to make the difference between EGit and the Mylyn extension more clear?

Line:13, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider.java -> Javadoc reference to internal classes?

-------------------------------------
author: Marley Hopkins
date: 2011-01-17 13:41:51.000000000

Patch Set 11:

Several minor issues, doesn't apply cleany currently. I think we can handle this today/tomorrow as part of the EGit summit.

-------------------------------------
author: Marley Hopkins
date: 2011-01-17 15:15:11.000000000

Patch Set 11: No score

I'm working on this right now..

-------------------------------------
author: Marley Hopkins
date: 2011-01-17 16:49:45.000000000

Patch Set 11: (15 inline comments)

This change was split up into change 2258 and I34454662

Line:2, org.eclipse.egit.mylyn/plugin.properties -> Done

Line:9, org.eclipse.egit.mylyn/plugin.properties -> Done

Line:23, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/internal/MylynCommitMessageProvider.java -> Done

Line:5, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> Done

Line:14, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> Done

Line:19, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> Done

Line:20, org.eclipse.egit.mylyn/META-INF/MANIFEST.MF -> Done

Line:4, org.eclipse.egit.ui/plugin.xml -> Done

Line:21, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Done

Line:43, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Done

Line:54, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Done

Line:64, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Done

Line:72, org.eclipse.egit.mylyn/src/org/eclipse/egit/mylyn/EgitMylynPlugin.java -> Done

Line:5, org.eclipse.egit.mylyn/plugin.xml -> As it's part of egit.ui, the id fits.

Line:13, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider.java -> Doesn't matter, class will be internal anyway before 1.0

-------------------------------------
author: Marley Hopkins
date: 2011-01-18 13:50:16.000000000

Patch Set 11: Do not submit

Thorsten, could you please abondon this change as it was split and merged into the master repo. Thanks for your efforts!

-------------------------------------
author: Malia Sampson
date: 2011-01-18 14:10:29.000000000

Patch Set 11: Do not submit

Thorsten, can you abandon this change?

-------------------------------------
author: Kennedi Macias
date: 2011-01-18 14:17:32.000000000

Patch Set 11: Abandoned

As wished from Anabel Bass and Chris...the changes was splitted and merged with the repo.

-------------------------------------
