DESCRIPTION

* Refactored existing test case * Moved to using page objects * (http://code.google.com/p/webdriver/wiki/PageObjects)

Other (minor) changes:
- removed dependency on junit 3.x (this should have been a plugin
  dependency, not a project dependency)
- moved to junit 4.x


COMMENTS

author: Juliet Cantu
date: 2010-01-26 07:23:04.000000000

Patch Set 1: No score; Unclean IP, do not check in

Unclear whether this requires the CQ process so I'll pass it that way.

-------------------------------------
author: Yoselin Hanna
date: 2010-01-26 15:06:08.000000000

Patch Set 1: No score

Yup, this requires a CQ.  Any EGit change over 250 lines of code by a non-EGit committer requires a CQ, even if the developer is a committer on another Eclipse project.  (At least, that's my understanding of the IP policy.)

-------------------------------------
author: Douglas Trujillo
date: 2010-01-26 15:47:24.000000000

Patch Set 1: No score

I think we want the squashed change http://egit.eclipse.org/r/#change,137 patchset 4 containing Robin's and Ketan's changes to go into master, but is it ok to put this squashed change into CQ or do we need to get the approval for Ketan's contribution http://egit.eclipse.org/r/#change,208 patchset 1 separately ?

-------------------------------------
author: Juliet Cantu
date: 2010-01-27 21:33:41.000000000

Patch Set 1:

I passed Ketans patch as CQ 3738 for those than can access it.

-------------------------------------
author: Juliet Cantu
date: 2010-01-27 21:37:59.000000000

Patch Set 1:

Now to sometheing entirely different. This test fine with Eclipse 3.4 SDk but not Eclipse 3.5 for JEE

!STACK 0
org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:3884)
	at org.eclipse.swt.SWT.error(SWT.java:3799)
	at org.eclipse.swt.SWT.error(SWT.java:3770)
	at org.eclipse.swt.widgets.Display.error(Display.java:1150)
	at org.eclipse.swt.widgets.Display.checkDevice(Display.java:712)
	at org.eclipse.swt.widgets.Display.addFilter(Display.java:519)
	at org.eclipse.mylyn.internal.monitor.ui.WorkbenchUserActivityMonitor.start(WorkbenchUserActivityMonitor.java:42)
	at org.eclipse.mylyn.internal.monitor.ui.ActivityContextManager$4.run(ActivityContextManager.java:123)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.mylyn.internal.monitor.ui.ActivityContextManager.start(ActivityContextManager.java:117)
	at org.eclipse.mylyn.internal.monitor.ui.MonitorUiPlugin.init(MonitorUiPlugin.java:408)
	at org.eclipse.mylyn.internal.monitor.ui.MonitorUiPlugin.start(MonitorUiPlugin.java:145)
	at org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:783)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:774)
	at org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:755)
	at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:352)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle.java:280)
	at org.eclipse.osgi.framework.util.SecureAction.start(SecureAction.java:408)
	at org.eclipse.core.runtime.internal.adaptor.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:111)
	at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:449)
	at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:211)
	at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:381)
	at org.eclipse.osgi.internal.loader.SingleSourcePackage.loadClass(SingleSourcePackage.java:33)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:454)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:410)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:398)
	at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:105)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
	at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
	at java.lang.Class.getDeclaredConstructors0(Native Method)
	at java.lang.Class.privateGetDeclaredConstructors(Class.java:2389)
	at java.lang.Class.getConstructor0(Class.java:2699)
	at java.lang.Class.newInstance0(Class.java:326)
	at java.lang.Class.newInstance(Class.java:308)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadBundleActivator(AbstractBundle.java:152)
	at org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:751)
	at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:352)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle.java:280)
	at org.eclipse.osgi.framework.util.SecureAction.start(SecureAction.java:408)
	at org.eclipse.core.runtime.internal.adaptor.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:111)
	at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:449)
	at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:211)
	at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:381)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:457)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:410)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:398)
	at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:105)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
	at org.eclipse.osgi.internal.loader.BundleLoader.loadClass(BundleLoader.java:326)
	at org.eclipse.osgi.framework.internal.core.BundleHost.loadClass(BundleHost.java:231)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadClass(AbstractBundle.java:1193)
	at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:160)
	at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:874)
	at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)
	at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:51)
	at org.eclipse.ui.internal.WorkbenchPlugin$1.run(WorkbenchPlugin.java:267)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:52)
	at org.eclipse.ui.internal.WorkbenchPlugin.createExtension(WorkbenchPlugin.java:263)
	at org.eclipse.ui.internal.EarlyStartupRunnable.getExecutableExtension(EarlyStartupRunnable.java:117)
	at org.eclipse.ui.internal.EarlyStartupRunnable.run(EarlyStartupRunnable.java:66)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.Workbench$55.run(Workbench.java:2192)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

!ENTRY org.eclipse.mylyn.core 2 0 2010-01-27 22:26:36.375
!MESSAGE Activity monitor ''{0}'' was disabled due to a failure
[2010-01-27T10-26-36] Status WARNING: org.eclipse.mylyn.core code=0 Activity monitor ''{0}'' was disabled due to a failure null,

-------------------------------------
author: Desirae Wilkerson
date: 2010-01-27 21:38:44.000000000

Patch Set 1: No score

I can file multiple patches for different tests if that helps :P

-- Ketan

-------------------------------------
author: Juliet Cantu
date: 2010-01-27 21:50:17.000000000

Patch Set 1:

For this kind of patch I'd rather see one complete patch.

-------------------------------------
author: Juliet Cantu
date: 2010-01-27 21:53:56.000000000

Patch Set 1:

WT.... I'll try with an upgraded/uninstalled mylyn.

-------------------------------------
author: Juliet Cantu
date: 2010-01-27 22:35:05.000000000

Patch Set 1: Looks good to me, approved

Works with Eclipse SDK 3.5 too. Technically this one is ok. 
We still need the CQ though.

-------------------------------------
author: Juliet Cantu
date: 2010-01-29 05:06:25.000000000

Patch Set 1:

The CQ's been improved. Mathias raise a few questions on CQ's (on the jgit mailing list) so we'll hold this one patch until those questions have been resolved.

-------------------------------------
author: Juliet Cantu
date: 2010-02-02 07:18:27.000000000

Patch Set 1:

Squashed into Ibc4c7a5ad6d9747fceb516c02d96dfc2b09d3b5a

This changeset should therefore be abandoned

-------------------------------------
author: Yoselin Hanna
date: 2010-02-02 14:48:54.000000000

Patch Set 1: Abandoned

Squashed into Ibc4c7a5ad6d9747fceb516c02d96dfc2b09d3b5a.

-------------------------------------
