DESCRIPTION

Implement UI Tests for http authentication

Implements a test for the clone wizard using http authentication.
Depends on JGit Change I13bfc4c6c47e27d8f97d3e9752347d6d23e553d4

Change-Id: Ibe56d8e7352a121431e02ebeceab158267945843
Signed-off-by: Marlie Beasley xxx@xxx.xxx


COMMENTS

author: Marlie Beasley
date: 2010-12-08 14:36:55.000000000

Uploaded patch set 3.

-------------------------------------
author: Douglas Trujillo
date: 2010-12-08 15:39:47.000000000

Patch Set 3: I would prefer that you didn't submit this

(14 inline comments)

verified successfully, but some room for improvements

maybe we should add a test with wrong credentials to prove that authentication is really used

Line:36, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> style nit: trailing whitespace

Line:43, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> style nit: trailing whitespace

Line:95, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> style nit: trailing whitespace

Line:100, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> style nit: trailing whitespace

Line:66, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> style nit: trailing whitespace

Line:89, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> style nit: trailing whitespace

Line:90, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> style nit: trailing whitespace

Line:166, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> style nit: trailing whitespace

Line:1, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> missing license header

Line:40, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> style nit: trailing whitespace

Line:43, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> style nit: trailing whitespace

Line:48, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> style nit: trailing whitespace

Line:72, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> typo: s/have/has/

Line:38, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java -> style nit: trailing whitespace

-------------------------------------
author: Marlie Beasley
date: 2010-12-08 16:17:28.000000000

Patch Set 3: (13 inline comments)

- rebased to current master
- will add test for failing login in a separate commit

Line:36, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> Done

Line:43, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> Done

Line:95, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> Done

Line:100, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepoPropertiesPage.java -> Done

Line:66, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> Done

Line:89, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> Done

Line:90, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> Done

Line:166, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/SampleTestRepository.java -> Done

Line:40, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> Done

Line:43, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> Done

Line:48, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> Done

Line:72, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> Done

Line:38, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java -> Done

-------------------------------------
author: Marlie Beasley
date: 2010-12-08 16:20:12.000000000

Patch Set 3: (1 inline comment)



Line:1, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTestBase.java -> Done

-------------------------------------
