DESCRIPTION

Implement basic authentification

Implementation of basic authentification with user and password.
User and password entered in the clone wizard are put in the Eclipse
secure store. A credentials provider was implemented that fetches
credentials from the secure store and ask the user if credentials are
not available.

Change-Id: I5239c6595e39d2a855318649fccc8fe8ac5e5fb8
Signed-off-by: Marlie Beasley xxx@xxx.xxx
Signed-off-by: Akira Shields xxx@xxx.xxx


COMMENTS

author: Marlie Beasley
date: 2010-11-29 17:13:59.000000000

Uploaded patch set 4.

-------------------------------------
author: Douglas Trujillo
date: 2010-11-29 23:04:37.000000000

Patch Set 4: (13 inline comments)



Line:25, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ChangeCredentialsCommand.java -> unnecessary blank line

Line:45, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ChangeCredentialsCommand.java -> The key for the externalized text has Push in its name, since this command is not related to push this key should be renamed to 
"ChangeCredentialsCommand_writingToSecureStoreFailed"

Line:3, org.eclipse.egit.ui/src/org/eclipse/egit/ui/credentials/LoginDialog.java -> missing blank line

Line:64, org.eclipse.egit.ui/src/org/eclipse/egit/ui/credentials/LoginDialog.java -> we don't use braces around single line blocks

Line:1318, org.eclipse.egit.ui/plugin.xml -> trailing whitespace

Line:1322, org.eclipse.egit.ui/plugin.xml -> trailing whitespace

Line:1703, org.eclipse.egit.ui/plugin.xml -> trailing whitespace

Line:3, org.eclipse.egit.ui/src/org/eclipse/egit/ui/credentials/EGitCredentialsProvider.java -> missing blank line

Line:27, org.eclipse.egit.ui/src/org/eclipse/egit/ui/credentials/EGitCredentialsProvider.java -> s/sent/shown/

Line:3, org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/UserPasswordCredentials.java -> missing blank line

Line:3, org.eclipse.egit.core.test/src/org/eclipse/egit/core/securestorage/EGitSecureStoreTest.java -> missing blank line

Line:115, org.eclipse.egit.core.test/src/org/eclipse/egit/core/securestorage/EGitSecureStoreTest.java -> unnecessary blank line

Line:3, org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitSecureStore.java -> missing blank line

-------------------------------------
