DESCRIPTION

Implement basic authentification

Implementation of basic authentification with user and password.
User and password entered in the clone wizard are put in the Eclipse
secure store. A credentials provider was implemented that fetches
credentials from the secure store and ask the user if credentials are
not available.

Change-Id: I5239c6595e39d2a855318649fccc8fe8ac5e5fb8
Signed-off-by: Marlie Beasley xxx@xxx.xxx
Signed-off-by: Akira Shields xxx@xxx.xxx


COMMENTS

author: Marlie Beasley
date: 2010-11-26 11:52:21.000000000

Uploaded patch set 2.

-------------------------------------
author: Douglas Trujillo
date: 2010-11-26 16:38:55.000000000

Patch Set 2: I would prefer that you didn't submit this

(5 inline comments)



Line:28, org.eclipse.egit.ui/META-INF/MANIFEST.MF -> replace with [1.0.0,2.0.0) to allow platform version range Galileo ... Indigo

Line:244, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java -> we don't use braces around single line blocks

Line:15, org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitCredentials.java -> maybe we find a more generic name here like "UserPasswordCredentials"

Line:17, org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitCredentials.java -> unnecessary blank line

Line:13, org.eclipse.egit.core/META-INF/MANIFEST.MF -> this should be a reasonable version range (lower boundary must be available in Galileo), use "[1.0.0,2.0.0)"

-------------------------------------
author: Marlie Beasley
date: 2010-11-26 17:12:01.000000000

Patch Set 2: (5 inline comments)



-------------------------------------
author: Marlie Beasley
date: 2010-11-26 17:12:00.000000000

MISMATCHED INLINE COMMENT
Line:28, org.eclipse.egit.ui/META-INF/MANIFEST.MF -> Done

-------------------------------------
author: Marlie Beasley
date: 2010-11-26 17:12:00.000000000

MISMATCHED INLINE COMMENT
Line:244, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java -> Done

-------------------------------------
author: Marlie Beasley
date: 2010-11-26 17:12:00.000000000

MISMATCHED INLINE COMMENT
Line:15, org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitCredentials.java -> Done

-------------------------------------
author: Marlie Beasley
date: 2010-11-26 17:12:00.000000000

MISMATCHED INLINE COMMENT
Line:17, org.eclipse.egit.core/src/org/eclipse/egit/core/securestorage/EGitCredentials.java -> Done

-------------------------------------
author: Marlie Beasley
date: 2010-11-26 17:12:00.000000000

MISMATCHED INLINE COMMENT
Line:13, org.eclipse.egit.core/META-INF/MANIFEST.MF -> Done

-------------------------------------
