DESCRIPTION

Extract class for dialog to clean up uncommitted changes

Change-Id: Ife7428006e8a8646e9258d52014dcef252b9d118


COMMENTS

author: Brenden Conley
date: 2013-11-26 14:11:12.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5373/

-------------------------------------
author: Brenden Conley
date: 2013-11-26 14:27:24.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5373/ : SUCCESS

-------------------------------------
author: Carlie Harper
date: 2013-11-27 12:02:20.000000000

Patch Set 1: Code-Review-1

I want to align it with the CheckoutConflictDialog

-------------------------------------
author: Carlie Harper
date: 2013-11-27 12:07:42.000000000

Patch Set 1: -Code-Review

No, the CheckoutConflictDialog is currently used when the initial action is not retriggered. The alignment should be done in another change.

-------------------------------------
author: Douglas Trujillo
date: 2013-11-27 22:17:33.000000000

Patch Set 1: Code-Review-1

(3 comments)

Line:39, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/CleanupUncomittedChangesDialog.java -> s/different//

remove the extra blank line

Line:118, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/CleanupUncomittedChangesDialog.java -> this sentence is incomplete

Line:408, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchOperationUI.java -> I would prefer to use braces around this pretty large block

-------------------------------------
author: Douglas Trujillo
date: 2013-11-27 22:21:14.000000000

Patch Set 1:

(3 comments)

Line:39, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/CleanupUncomittedChangesDialog.java -> Done

Line:118, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/CleanupUncomittedChangesDialog.java -> Done

Line:408, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchOperationUI.java -> Done

-------------------------------------
